feat: --skip-dependency-resolution for config install

[patrickleet]

Summary by CodeRabbit

• New Features

  • Added --skip-dependency-resolution flag to control dependency resolution in generated configurations

• Documentation

  • Improved configuration installation documentation with clearer distinction between source-build and remote-package installation modes
  • Added documentation for the new flag and clarified behavior across different installation scenarios

[coderabbitai]

📝 Walkthrough

Walkthrough

This pull request introduces a --skip-dependency-resolution CLI flag to the config install command, allowing users to control dependency resolution behavior during package installation. The flag is threaded through multiple code paths and documented in updated installation guides covering both source-build and remote-package installation modes.

Changes

Cohort / File(s)	Summary
Documentation Updates README.md	Removed "Quick Start" section and restructured config installation documentation. Added detailed explanation of two installation modes (source-build vs. remote-package). Documented new --skip-dependency-resolution flag, updated example configuration names, and clarified --reload and --version behavior.
Config Install Implementation src/commands/config/install.rs	Added skip_dependency_resolution boolean field to ConfigArgs struct with CLI flag binding. Updated function signatures for apply_repo_version(), run_repo_clone(), and run_local_path() to accept and thread the new flag. Modified build_configuration_yaml() to conditionally emit spec.skipDependencyResolution: true. Updated unit tests to include the new field in ConfigArgs construction.

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

Poem

🐰 A flag hops forth, so small yet grand,
Through config paths it takes command,
With skip-dependency's gentle touch,
Dependencies need not be much! ✨
Docs shine bright with clearer sight,
Installation modes now feel just right.

🚥 Pre-merge checks | ✅ 2 | ❌ 1

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 18.18% which is insufficient. The required threshold is 80.00%.	Write docstrings for the functions missing them to satisfy the coverage threshold.

✅ Passed checks (2 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title accurately and concisely describes the main change: adding a --skip-dependency-resolution flag to the config install command.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

📝 Generate docstrings

• Create stacked PR
• Commit on current branch

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch feat/skip-dep-res

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[coderabbitai]

🧹 Nitpick comments (1)

src/commands/config/install.rs (1)

481-486: Outdated comment should be updated.

The comment at lines 481-482 states "skipDependencyResolution is intentionally not set" but this is now incorrect since the flag can control this behavior. Consider updating the comment to reflect the current implementation.

📝 Suggested comment update

-    // Apply Crossplane Configuration resources and let Crossplane resolve
-    // dependencies (skipDependencyResolution is intentionally not set).
+    // Apply Crossplane Configuration resources. By default, Crossplane resolves
+    // dependencies unless --skip-dependency-resolution is specified.
     for pull_ref in &config_pull_refs {

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.

In `@src/commands/config/install.rs` around lines 481 - 486, Update the outdated
comment above the loop that iterates over config_pull_refs: reflect that
skip_dependency_resolution may be set by the flag rather than saying it is
"intentionally not set." Locate the loop using config_pull_refs and the call to
apply_configuration(name, pull_ref, skip_dependency_resolution, reload) and
change the comment to state that dependency resolution behavior is controlled by
skip_dependency_resolution (the flag) or document the current behavior clearly.

🤖 Prompt for all review comments with AI agents

Verify each finding against the current code and only fix it if needed.

Nitpick comments:
In `@src/commands/config/install.rs`:
- Around line 481-486: Update the outdated comment above the loop that iterates
over config_pull_refs: reflect that skip_dependency_resolution may be set by the
flag rather than saying it is "intentionally not set." Locate the loop using
config_pull_refs and the call to apply_configuration(name, pull_ref,
skip_dependency_resolution, reload) and change the comment to state that
dependency resolution behavior is controlled by skip_dependency_resolution (the
flag) or document the current behavior clearly.

---

ℹ️ Review info

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 250a7b50-7c4e-475e-99cc-542699215e8d

📥 Commits

Reviewing files that changed from the base of the PR and between 883a11e and e1f4996.

📒 Files selected for processing (2)

• README.md
• src/commands/config/install.rs