feat: file-based env vars for e2e tests

[patrickleet]

Summary

• Replace hardcoded AWS account IDs, subnet IDs, and environment-specific values in KCL e2e tests with file.read("env/...") pattern
• CI writes env files from GitHub repo variables (${{ vars.* }}) via shared e2e workflow v2.19.1
• Add tests/**/env/ to .gitignore
• Update all workflow versions to v2.19.1

Why

KCL cannot read environment variables but can read files. This makes e2e tests fully portable — enterprise forks only need to set their own GitHub repo variables, no code changes needed.

Test plan

• Validate job passes (no KCL changes needed)
• Unit tests pass
• E2e test passes with values from GitHub repo variables

🤖 Generated with Claude Code

[coderabbitai]

Warning

Rate limit exceeded

@patrickleet has exceeded the limit for the number of commits that can be reviewed per hour. Please wait 29 minutes and 54 seconds before requesting another review.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

ℹ️ Review info

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 2039eacd-10d8-41a0-b616-8770bc655aea

📥 Commits

Reviewing files that changed from the base of the PR and between c02be1f and 70fde69.

📒 Files selected for processing (4)

• .github/workflows/on-pr.yaml
• .github/workflows/on-push-main.yaml
• .gitignore
• tests/e2etest-dnsstack/main.k

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Post copyable unit tests in a comment
• Commit unit tests in branch e2e/github-vars

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[github-actions]

Published Crossplane Package

The following Crossplane package was published as part of this PR:

Package: ghcr.io/hops-ops/aws-dns-stack:pr-1-6a159e82f711f382383a0a78c4bbbfa440d2843b

View Package