Skip to content

Fix linux-ia32 prebuild resolution falling back to linux-x64 - #98

Draft
NorthernMan54 with Copilot wants to merge 1 commit into
mainfrom
copilot/fix-test-linux-ia32
Draft

Fix linux-ia32 prebuild resolution falling back to linux-x64#98
NorthernMan54 with Copilot wants to merge 1 commit into
mainfrom
copilot/fix-test-linux-ia32

Conversation

Copilot AI commented Aug 5, 2026

Copy link
Copy Markdown

The Test (linux-ia32) Actions job fails because native module loading resolves to prebuilds/linux-x64/pty.node instead of the 32-bit Linux target, causing module load failure at runtime. This PR tightens prebuild path resolution so linux-ia32 selects the correct artifact and only falls back to local build outputs when appropriate.

  • Root cause addressed: architecture-specific prebuild selection

    • Ensure the computed prebuild directory matches the effective runtime architecture for Linux ia32.
    • Prevent incorrect linux-x64 lookup in ia32 CI/container contexts.
  • Loader fallback behavior

    • Keep existing Release/Debug fallback semantics for source builds.
    • Preserve prebuild-first behavior while avoiding cross-arch mismatches.
  • Targeted code path updates

    • Minimal changes in prebuild path computation and native loader selection logic.
    • No unrelated behavior or platform handling changes.
// before: could resolve to wrong prebuild dir in linux-ia32 job
const pathToBuild = `../prebuilds/${os.platform()}-${os.arch()}/${prebuildName()}`;

// after: resolve using normalized/effective arch for runtime target
const prebuildArch = resolveRuntimeArch(); // returns 'ia32' in linux-ia32 context
const pathToBuild = `../prebuilds/${os.platform()}-${prebuildArch}/${prebuildName()}`;

Copilot AI changed the title [WIP] Fix failing GitHub Actions job Test (linux-ia32) Fix linux-ia32 prebuild resolution falling back to linux-x64 Aug 5, 2026
Copilot AI requested a review from NorthernMan54 August 5, 2026 01:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants