Repository navigation
fix: remove yamldecode validation from product-demo configuration_yaml - #142
Merged
Merged
Conversation
Terraform's yamldecode() implements plain YAML 1.2 and rejects unknown tags. Home Assistant's configuration.yaml relies on custom tags such as !include, !secret and !env_var, so any realistic config fails the check: configuration_yaml must be valid YAML syntax There is no way to whitelist tags in yamldecode(), so the validation is removed rather than tightened.
There was a problem hiding this comment.
Pull request overview
This PR fixes failing Terraform runs for product-demo by removing a variable validation that attempted to parse Home Assistant’s configuration.yaml using Terraform’s yamldecode(), which rejects Home Assistant’s custom YAML tags.
Changes:
- Removed
yamldecode()-based validation from theconfiguration_yamlvariable to avoid false failures on valid Home Assistant configs. - Added an explanatory comment documenting why validation is intentionally omitted.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
frenck
approved these changes
Aug 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Terraform runs for
product-demofail with:Cause
yamldecode()implements plain YAML 1.2 and rejects unknown tags. Home Assistant'sconfiguration.yamlrelies on custom tags that its own loader resolves —!include,!include_dir_merge_list,!secret,!env_var— so any realistic config fails the validation.Fix
Remove the validation block. There's no way to whitelist tags in
yamldecode(), so it can't be tightened to accept HA syntax — a comment in its place records why.