fix: TS types for getSessionById#11
Open
famouswizard wants to merge 1 commit intoholonym-foundation:mainfrom
Open
fix: TS types for getSessionById#11famouswizard wants to merge 1 commit intoholonym-foundation:mainfrom
famouswizard wants to merge 1 commit intoholonym-foundation:mainfrom
Conversation
calebtuttle
added a commit
that referenced
this pull request
Apr 30, 2026
- v3 returns 400 (was 404) for not-yet-IN_PROGRESS sessions, matching Onfido v3 — frontend retry policy treats 4xx alike (#7). - v3 saveUserToDb gated by environment === 'live', matching Onfido sandbox semantics (#10). - routes/idenfy.ts: explicit comment block listing the legacy endpoints removed in U0 so future readers see the deprecation paper trail (#11). - IdenfyVerificationData.finishTime/creationTime added to type; drop 'as any' casts in extractCreds (#12). - Extract IDENFY_BASE_URL/getIdenfyCredentials/idenfyBasicAuthHeader to a shared services/idenfy/http.ts module; token.ts and data.ts both consume it (#14). - console.log -> pino logger.error in saveCollisionMetadata and updateSessionStatus (#15). - Drop noisy 'U0 audit:' inline comments in schemas.ts; collapse to one short comment explaining the legacy provider-history block (#16).
calebtuttle
added a commit
that referenced
this pull request
May 1, 2026
- v3 returns 400 (was 404) for not-yet-IN_PROGRESS sessions, matching Onfido v3 — frontend retry policy treats 4xx alike (#7). - v3 saveUserToDb gated by environment === 'live', matching Onfido sandbox semantics (#10). - routes/idenfy.ts: explicit comment block listing the legacy endpoints removed in U0 so future readers see the deprecation paper trail (#11). - IdenfyVerificationData.finishTime/creationTime added to type; drop 'as any' casts in extractCreds (#12). - Extract IDENFY_BASE_URL/getIdenfyCredentials/idenfyBasicAuthHeader to a shared services/idenfy/http.ts module; token.ts and data.ts both consume it (#14). - console.log -> pino logger.error in saveCollisionMetadata and updateSessionStatus (#15). - Drop noisy 'U0 audit:' inline comments in schemas.ts; collapse to one short comment explaining the legacy provider-history block (#16).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
tightened up the types so TS stops complaining:
objectIdis nowObjectIdinstead ofnullgetSessionByIdnow TS knows we either get an error or a session with its ID.