show: fetch specific subtree instead of full control-plane-protocols#33
Open
sha90w wants to merge 1 commit into
Open
show: fetch specific subtree instead of full control-plane-protocols#33sha90w wants to merge 1 commit into
sha90w wants to merge 1 commit into
Conversation
Add a `fetch_path` option to `YangTableBuilder` and update the OSPF, RIP, MPLS LDP, and BGP detail/summary show commands to query the specific instance subtree rather than the entire `/ietf-routing:routing/control-plane-protocols` tree. This reduces the amount of state retrieved. Also handle the empty-result case in `isis_hostnames` and `ospf_hostnames` by replacing `find_path(...).unwrap()` with a let-else that returns an empty map.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add a
fetch_pathoption toYangTableBuilderand update the OSPF, RIP, MPLS LDP, and BGP detail/summary show commands to query the specific instance subtree rather than the entire/ietf-routing:routing/control-plane-protocolstree. This reduces the amount of state retrieved.Also handle the empty-result case in
isis_hostnamesandospf_hostnamesby replacingfind_path(...).unwrap()with a let-else that returns an empty map.