Make reconcile Linear - should solve partially #282#334
Open
xdecock wants to merge 1 commit intohlandau:masterfrom
Open
Make reconcile Linear - should solve partially #282#334xdecock wants to merge 1 commit intohlandau:masterfrom
xdecock wants to merge 1 commit intohlandau:masterfrom
Conversation
Author
|
well the rest of the slowness is linked to that part : https://github.com/hlandau/acmetool/blob/master/storage/storage-fdb.go#L400 actualKeyID, err := determineKeyIDFromKey(pk)
if err != nil {
return err
}Keeping that section solves our 1300 record in ~2Min CPU time, vs 13 seconds, without, i suspect the rand.Reader is the problem here, and can probably lead to entropy starvation on some server. Could we add a switch to bypass this check? The PR here, brought our response time down from 35 minutes. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Basically,
loops a first time over certificates to create a map name => certs[], this allows for lookup of the possible certificates, which allows way faster matching.