Repository navigation
Polish agent answers: one-round write errors, no-match not an error, shorter instructions, UTF-8 - #43
Merged
Conversation
…rror, date order only for real dates, shorter instructions, UTF-8 charset
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Polish only, no new features. Fixes rough edges found in the end-to-end walk.
create_item/update_itemadvertise types, required fields and limits (JSON Schema unchanged in shape:type,description) but no longer enforce them, so the SDK does not stop at its own first pass. The save check reports everything, merged with non-string values and the plain-Generalsummaryrefusal, with the field list once at the end. Entity key and label problems are included.list_itemsbyqorentity_key(isErrorfalse, tells the agent to say it is not there).charset=utf-8on MCP responses (src/http/utf8-charset.ts).Tests: new
test/agent-polish.test.ts; updated three tests that asserted the old SDK-level rejection. Verified live on a fresh Compose stack over OAuth: one bad write returned 7 issues in one answer, no-matchisError: false,content-type: text/event-stream; charset=utf-8.