Repository navigation
Fix deep-test findings (PG18 volume, sign-out 401, audit page, Reader key, UX) - #40
Merged
Merged
Conversation
…rnames, audit page, Reader key, and UX polish
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes the findings from the deep test of a fresh deploy, in one PR.
Breaking
postgres18_data, mounted at/var/lib/postgresql. Postgres 18 would not start on the old mount. Existing Compose installs must dump and restore or pin Postgres 16; the steps are in docs/deploy.md and CHANGELOG.update_itemkeeps any field you leave out. Passreplace: trueto get the old whole-item replace.Must-fix
WWW-Authenticateand "Your sign-in ended; reconnect". A disabled account still gets its own message.list_audit/auditpage with paging (Site admin: all events; Publisher: their libraries)/libraries/<id>/mcp, with no "rotate Connect" advice; Readers don't see rotate adviceNice-to-have
update_itempartial updates plus areplaceflagentity_keyupsert oncreate_itemscopereflects the library roletools/list_changed: not feasible because each MCP request builds a fresh stateless server. The field-approval wording now says the next request picks up the change.Testing
test/deep-test-findings.test.tsandtest/deep-test-http.test.ts.npm testpasses 405/405; lint, typecheck andnpm auditare clean.docker-compose.yml(Postgres 18, no override) and reran the deep-test checks.