Repository navigation
test: pin skills/promptargs/SKILL.md against the CLI and the agentskills.io spec - #236
Merged
Merged
Conversation
…lls.io spec Nothing in the suite read the Agent Skill shipped in #234, so a renamed subcommand or flag, a template run that lost --no-interactive, or a README install snippet pointing at a deleted file would all merge green. skill.test.ts parses the SKILL.md frontmatter and bash fences, checks every documented promptargs command names a real subcommand/init template and real switches or template variables, requires --no-interactive on template runs, executes each command against dist/cli.js in a scratch directory after init, and verifies the README raw.githubusercontent.com / cp -r targets exist and also document --no-interactive. Closes #235 Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Signed-off-by: quality <quality@hive.kubestellar.io>
kubestellar-prow
Bot
added
the
dco-signoff: yes
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
kubestellar-prow
Bot
added
the
size/L
|
Thank you for your contribution! Your PR has been merged. We'd love to hear how your experience was: share feedback |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Test Improvement
PR #234 shipped
skills/promptargs/SKILL.mdas an Agent Skill, but nothing in the suite read it — so a renamed subcommand or flag incli.ts/flags.ts, a template run that lost--no-interactive, or a README install snippet pointing at a deleted file would all merge green.This adds
src/skill.test.ts(compiled intodist/, picked up automatically byscripts/run-tests.mjs), following theexamples.test.ts/package.test.tsdrift-test pattern:namematches the directory, lowercase/hyphens, ≤64 chars;description≤1024 chars; only spec-known fieldspromptargs …command in a bash fence names a real subcommand or aninittemplate, and every--flagis a CLI switch or a variable of that template (resolved fromexamples/<name>.md)--no-interactivedist/cli.jsin a scratch dir afterinit: exit 0, non-empty output, no leftover{{…}}--statusis one line)raw.githubusercontent.com/…andcp -r skills/promptargstargets exist, and the.claude/,.goose/,.bob/copies also document--no-interactiveMutation-checked: misspelling
--focus→--foucsand dropping--no-interactivein SKILL.md fails two tests with the offending command in the message.Validation:
npm run build && npm teston Node 26.10 — 368 pass, coverage thresholds hold (test files are excluded from measurement).dist/output and achangelog.d/added-*fragment are committed per CI's dist-sync gate.Closes #235
Filed by quality agent (ACMM L4/L6 — full mode)
— hive: agent=quality backend=copilot model=claude-fable-5.1 copilot=1.0.88