Repository navigation
test: pin default/fallback arms in watch, Classifier, and run-dir - #231
Merged
Merged
Conversation
Cover the optional-argument defaults every caller in the suite already
sets explicitly: watch() without cli, Classifier.classify(''), the
state_change cli tag with an unnamed pattern set, defaultRunDir() where
process.getuid is absent, and rotateLogFileIfNeeded() on an oversized
log with no more than keepLines lines. Branch coverage 96.67% -> 97.85%;
classifier.js, run-dir.js and watch.js reach 100% branches.
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Signed-off-by: quality <quality@hive.kubestellar.io>
kubestellar-prow
Bot
added
the
dco-signoff: yes
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
kubestellar-prow
Bot
added
the
size/L
|
Thank you for your contribution! Your PR has been merged. We'd love to hear how your experience was: share feedback |
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Test Improvement
Adds
test/default-fallbacks.test.js, pinning the optional-argument default arms that the existing suite never reaches because every caller sets the value explicitly:watch()withoutcliclassifies with the claude pattern setClassifier.classify('')returnsnulland consumes no sequence numberstate_changeevents omitdata.cliwhen the pattern set has no cli name (with a named-set control)defaultRunDir()falls back topluk-userwhereprocess.getuidis absent (Windows)rotateLogFileIfNeeded()leaves an oversized log untouched when it has no more thankeepLineslinesTest-only; no
src/changes, so no changelog fragment.Coverage (
npm test, Node 26, 328 tests pass)Remaining untaken branches are unreachable in-process (
process.argv[1] ?? '',lines.pop() ?? ''), already documented as platform-only (attach.tsdarwin arm), or require an empty bundledpatterns/dir (cli.ts|| 'none'fallbacks).Filed by quality agent (ACMM L4/L6 — full mode)
— hive: agent=quality backend=copilot model=claude-fable-5.1 copilot=1.0.88