Skip to content

πŸ“– docs: drop 'awaiting operator review' from the Level 6 guide index entry - #10728

Merged
clubanderson merged 1 commit into
v5from
docs/l6-guide-reviewed-10515
Oct 6, 2026
Merged

clubanderson merged 1 commit into
v5from
docs/l6-guide-reviewed-10515

Conversation

@clubanderson

Copy link
Copy Markdown
Member

Removes the stale awaiting operator review caveat from the Level 6 guide entry in documentation-map.md. The in-page notice was already dropped in #10704 and the guide is live at https://docs.hivecommons.dev/docs/hive/running-at-level-6 with the dashboard link from #10684.

Fixes #10515

…entry

The guide was published and reviewed under operator decision on #10515
(hive #10704 removed the in-page notice); documentation-map.md still
carried the old caveat.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Signed-off-by: Andrew Anderson <andy@clubanderson.com>
@kubestellar-prow kubestellar-prow Bot added the dco-signoff: yes Indicates the PR's author has signed the DCO. label Oct 6, 2026
@kubestellar-prow

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign hanthor for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubestellar-prow kubestellar-prow Bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Oct 6, 2026
@github-actions

github-actions Bot commented Oct 6, 2026

Copy link
Copy Markdown
Contributor

Open PR overlap check

Base branch: v5

Conflicts are checked with every PR merged onto the current tip of v5, so a PR that only needs a rebase is not reported as conflicting with its siblings.

No conflicting open PRs or same-file overlaps were found.

@hivecommons-hive hivecommons-hive Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs a maintainer decision before this lands β€” the one-line edit is fine, but what it closes is not.

Two things I verified against v5:

  1. #10515 is still open and labelled hold. It is the maintainer sign-off tracker for the Level 6 guide. This PR says Fixes #10515, so merging it would close that issue by keyword β€” i.e. an agent PR would mark the operator review as done. Whether the guide has been signed off is a decision only a maintainer can record; the sign-off isn't something this diff performs.

  2. The guide itself still instructs the opposite. src/docs/running-at-level-6.md:283 reads: "Maintainer review of this guide and its promotion belong to #10515, not an agent review. Until that sign-off, retain the notice and the index's awaiting-review label." #10704 removed the top-of-page notice but left this paragraph, so after this PR the guide would still tell readers to retain an index label that no longer exists.

The body's premise β€” "the in-page notice was already dropped in #10704" β€” is accurate, but that removal was itself ahead of #10515, so it isn't evidence of sign-off.

Question for a maintainer (@clubanderson, as #10515's owner): has the Level 6 guide been signed off?

  • If yes: this PR is correct; I'd also drop or rewrite the paragraph at running-at-level-6.md:283 in the same change so the guide stops pointing at a label that is gone, and let Fixes #10515 stand.
  • If no: change Fixes #10515 to Refs #10515 (or restore the label) so the hold-tracked issue stays open until a human closes it.

I have not changed anything.

β€” hive: agent=reviewer backend=copilot model=claude-fable-5.1 copilot=1.0.88

@clubanderson
clubanderson merged commit 43d631f into v5 Oct 6, 2026
65 of 68 checks passed
@clubanderson
clubanderson deleted the docs/l6-guide-reviewed-10515 branch October 6, 2026 00:15
@github-actions

github-actions Bot commented Oct 6, 2026

Copy link
Copy Markdown
Contributor

Thank you for your contribution! Your PR has been merged.

We'd love to hear how your experience was: share feedback

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dco-signoff: yes Indicates the PR's author has signed the DCO. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

πŸ“– docs: sign off and promote the Level 6 best-practices guide (review, links, switch notice)

1 participant