Skip to content

🌱 ci: run lint/build for meeting-recordings refresh PRs without a GitHub App - #391

Merged
hivecommons-hive[bot] merged 1 commit into
mainfrom
ci/refresh-pr-dispatch-ci
Oct 19, 2026
Merged

hivecommons-hive[bot] merged 1 commit into
mainfrom
ci/refresh-pr-dispatch-ci

Conversation

@clubanderson

Copy link
Copy Markdown
Member

Why

The daily Refresh meeting recordings PR is pushed and opened with GITHUB_TOKEN, and GitHub never creates pull_request runs for such events. Since Lint and build, TypeScript & ESLint, Run unit tests and Audit production dependencies are required status checks on main, every refresh PR sat blocked (#331). #296/#305 added a create-github-app-token path that needs two repo secrets which were never provisioned.

Decision: no new secrets (option B)

workflow_dispatch and repository_dispatch are the two events GitHub does allow GITHUB_TOKEN to trigger, and a workflow_dispatch run on a branch reports its job check-runs on that branch's head SHA — which is exactly what branch protection keys on (contexts by job name, app_id 15368 = GitHub Actions).

Verified locally with actionlint and scripts/changelog-fragments.test.ts. After merge I will trigger Refresh meeting recordings via workflow_dispatch and confirm the four check-runs appear on the new PR's head SHA.

Closes #337
Closes #335

…Hub App

PRs pushed/opened with GITHUB_TOKEN never get pull_request runs, so the
required checks (Lint and build, TypeScript & ESLint, Run unit tests,
Audit production dependencies) never landed on the refresh PR head and it
could not merge. Instead of provisioning a GitHub App and two secrets,
the refresh job now dispatches build/typecheck/vitest/npm-audit on the PR
branch via workflow_dispatch (allowed from GITHUB_TOKEN); those runs report
check-runs on the head SHA and satisfy branch protection.

Removes the create-github-app-token fallback machinery.

Signed-off-by: Andrew Anderson <andy@clubanderson.com>
@kubestellar-prow

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign clubanderson for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@netlify

netlify Bot commented Oct 19, 2026 •

Copy link
Copy Markdown

✅ Deploy Preview for hivecommons-docs ready!

Name Link
🔨 Latest commit 4f5beb1
🔍 Latest deploy log https://app.netlify.com/projects/hivecommons-docs/deploys/6ad63c6231f134d520e14939
😎 Deploy Preview https://deploy-preview-391--hivecommons-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@hivecommons-hive

Copy link
Copy Markdown
Contributor

@clubanderson is auto-promoted for contributor-lane merging on this PR: the last 5 merged PRs by this author in this repository have no revert or sentinel-alert evidence. CI, reviewer verdict, diff fences, soak, holds and branch protection still apply.

@hivecommons-hive hivecommons-hive Bot added author/human A person pushed this PR themselves dco All commits are DCO signed-off role/trusted Author is trusted for unattended merge (trusted-author role or registry/claim tier in require_tiers) stage/050-review-pending Review swarm requested; awaiting a verdict for the current head and removed dco-signoff: yes labels Oct 19, 2026
@hivecommons-hive

Copy link
Copy Markdown
Contributor
4f5beb1

ℹ️ Sentinel notice — informational; author is trusted (owner), merge is not blocked

Hive flagged this PR (author @clubanderson, head 4f5beb1f7d94) because it matches behaviors that can override security controls, escalate privileges or damage the codebase. This is a heuristic, not an accusation — a maintainer should confirm the change is intended before it merges.

  • sensitive_path — changes 5 sensitive path(s) (Touches a sensitive path (OWNERS, workflows, policies, hive config, security docs, …))
    • .github/workflows/build.yml
    • .github/workflows/meeting-recordings-refresh.yml
    • .github/workflows/npm-audit.yml
    • .github/workflows/typecheck.yml
    • .github/workflows/vitest.yml
  • permission_escalation — widens workflow permissions or uses pull_request_target (Widens GitHub Actions permissions or switches to pull_request_target)
    • .github/workflows/meeting-recordings-refresh.yml

Hive did not add the sentinel-alert label because this author is trusted. The finding remains recorded for audit and the dashboard Security tab; set sentinel.trusted_authors_block: true to require the blocking label for trusted authors too.

@hivecommons-hive
hivecommons-hive Bot merged commit b7a065e into main Oct 19, 2026
10 of 11 checks passed
@kubestellar-prow
kubestellar-prow Bot deleted the ci/refresh-pr-dispatch-ci branch October 19, 2026 16:18
@hivecommons-hive

Copy link
Copy Markdown
Contributor
Evidence bundle `#3914f5beb1` sha256:31eda09fad2934a68bed074fac7d188ec95a468b20ac5959b13f694258aef2e9 — download from the dashboard or `hivectl review evidence #391`.

@hivecommons-hive

Copy link
Copy Markdown
Contributor

merged by Hive trusted-author auto-merge: author @clubanderson holds role owner and GitHub permission admin on repo; CI green at 4f5beb1.

@hivecommons-hive hivecommons-hive Bot removed role/trusted Author is trusted for unattended merge (trusted-author role or registry/claim tier in require_tiers) stage/050-review-pending Review swarm requested; awaiting a verdict for the current head labels Oct 19, 2026
@clubanderson

Copy link
Copy Markdown
Member Author

/lgtm

@clubanderson

Copy link
Copy Markdown
Member Author

/approve

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

author/human A person pushed this PR themselves dco All commits are DCO signed-off size/M

Projects

None yet

1 participant