Repository navigation
🌱 ci: run lint/build for meeting-recordings refresh PRs without a GitHub App - #391
Conversation
…Hub App PRs pushed/opened with GITHUB_TOKEN never get pull_request runs, so the required checks (Lint and build, TypeScript & ESLint, Run unit tests, Audit production dependencies) never landed on the refresh PR head and it could not merge. Instead of provisioning a GitHub App and two secrets, the refresh job now dispatches build/typecheck/vitest/npm-audit on the PR branch via workflow_dispatch (allowed from GITHUB_TOKEN); those runs report check-runs on the head SHA and satisfy branch protection. Removes the create-github-app-token fallback machinery. Signed-off-by: Andrew Anderson <andy@clubanderson.com>
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
✅ Deploy Preview for hivecommons-docs ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
@clubanderson is auto-promoted for contributor-lane merging on this PR: the last 5 merged PRs by this author in this repository have no revert or sentinel-alert evidence. CI, reviewer verdict, diff fences, soak, holds and branch protection still apply. |
4f5beb1
ℹ️ Sentinel notice — informational; author is trusted (owner), merge is not blockedHive flagged this PR (author @clubanderson, head
Hive did not add the |
|
merged by Hive trusted-author auto-merge: author @clubanderson holds role owner and GitHub permission admin on repo; CI green at 4f5beb1. |
|
/lgtm |
|
/approve |
Why
The daily
Refresh meeting recordingsPR is pushed and opened withGITHUB_TOKEN, and GitHub never createspull_requestruns for such events. SinceLint and build,TypeScript & ESLint,Run unit testsandAudit production dependenciesare required status checks onmain, every refresh PR satblocked(#331). #296/#305 added acreate-github-app-tokenpath that needs two repo secrets which were never provisioned.Decision: no new secrets (option B)
workflow_dispatchandrepository_dispatchare the two events GitHub does allowGITHUB_TOKENto trigger, and aworkflow_dispatchrun on a branch reports its job check-runs on that branch's head SHA — which is exactly what branch protection keys on (contextsby job name,app_id15368 = GitHub Actions).build.yml,typecheck.yml,vitest.yml,npm-audit.ymlgainon: workflow_dispatch(npm-audit already had it).meeting-recordings-refresh.ymlHAS_APP_SECRETSenv;create-pull-requestreportscreated/updated, runsgh workflow run <wf> --ref automation/meeting-recordings-refreshfor the four CI workflows (actions: writeadded to the job);Verified locally with
actionlintandscripts/changelog-fragments.test.ts. After merge I will triggerRefresh meeting recordingsviaworkflow_dispatchand confirm the four check-runs appear on the new PR's head SHA.Closes #337
Closes #335