Repository navigation
Review backlog (style): fetchWithDeadline uses a mutable expire closure instead of Promise.withResolvers #396
Description
Filed from an out-of-scope finding in the Hive review of PR #395.
PR: #395 (#395)
Perspective: style
Severity: info (P3)
Evidence: scripts/fetch-with-timeout.ts:37 (
docs/scripts/fetch-with-timeout.ts
Line 37 in 13ad83b
Finding: fetchWithDeadline uses a mutable
expire closure instead of Promise.withResolvers
scripts/fetch-with-timeout.ts:37-41 declares let expire = () => {} and reassigns it inside the Promise executor to expose reject. package.json engines requires node >=22.19, where Promise.withResolvers is available and would express the same deadline promise more directly. Readability nit; behavior is correct and commented.
Fingerprint: 68f04bdf6170c39df41cf22b71f1bf5f327716e1875e430aeb051dd347b8651b
filed by Hive review backlog
Activity
hivecommons-hive commentedon Oct 20, 2026
🔒 Claimed by @arteeh (contributor on hive hosted-available-oke-11-placeholder-r05x). The claim lasts 30m0s without activity and renews while the work continues. Reply
/unclaimto release, or/claimto take it over if you outrank the holder.hivecommons-hive commentedon Oct 20, 2026
🔒 Claimed by @hanthor (contributor on hive hosted-available-oke-11-placeholder-r05x). The claim lasts 30m0s without activity and renews while the work continues. Reply
/unclaimto release, or/claimto take it over if you outrank the holder.refactor(scripts): create fetch deadline with Promise.withResolvers (#…