[ci-maintainer] path-filtered TypeScript & ESLint / Vitest checks can't be required — #300 merged with lint red, main broken 32 min #310

Activity

1. hivecommons-hive

   added

   hive/hosted-available-oke-11-placeholder-r05x

   ciCreated by Hive for agent-filed issue provenanceCreated by Hive for agent-filed issue provenance

   agent/ci-maintainerCreated by Hive for agent-filed issue provenanceCreated by Hive for agent-filed issue provenance

   needs-decision

   on Oct 11, 2026
2. hivecommons-hive commented on Oct 11, 2026

   

   hivecommons-hiveBot

   on Oct 11, 2026 – with hivecommons-hive

   ContributorAuthor

   More actions

   What to reply

   • /hive approve: go with the recommendation
   • /hive decision <your instructions>: go ahead, following your instructions
   • /hive help: show these again

   If this issue is waiting only for reporter confirmation after a merged fix, the reporter or a maintainer can reply /fixed instead.

   Only a maintainer with write access can un-park; everything else is ignored. Full command reference: https://github.com/hivecommons/hive/blob/v5/src/docs/maintainer-commands.md.
3. hivecommons-hive commented on Oct 13, 2026

   

   hivecommons-hiveBot

   on Oct 13, 2026 – with hivecommons-hive

   ContributorAuthor

   More actions

   Folded finding. This was filed as a separate issue, but 1 open agent-filed issue (plus 9 closed as completed in the last 14 days) already cite github/workflows/vitest.yml, so it was folded into the oldest of them instead of opening another. Treat this issue as the tracker for that component: prefer one structural fix that covers every folded variant over a PR per variant.

   [quality] rewriteLinks/rewriteLinkTarget image, protocol-relative and query branches untested in prebuild sync scripts

   Finding

   Type: coverage-gap

   The two prebuild sync scripts export link-rewriting helpers whose documented behaviours are not exercised by their unit suites:

   • scripts/sync-sibling-docs.ts rewriteLinks() — the docblock promises "relative image sources become raw.githubusercontent URLs", but the ![…](…) branch (line 433) has zero statement coverage; the synced-route-without-anchor branch (line 436) and ./-prefix stripping are also untested. Only three cases exist in scripts/sync-sibling-docs.test.ts.
   • scripts/sync-hive-docs.ts rewriteLinkTarget() — the protocol-relative (//…), empty-target and lone-?query skip branches (lines 171, 174, 177) are uncovered, as is ?query suffix preservation on a rewritten in-tree link.

   These helpers run on every npm run build (prebuild) and shape every link on synced sibling/hive pages, so a regression there silently breaks published docs rather than failing a test.

   Evidence

   • Unit: npx vitest run --coverage at 128d8b5 (main) — sync-sibling-docs.ts 98.97% stmts / 87.67% branches (uncovered: 433, 436, 479-511, 554); sync-hive-docs.ts 95.12% stmts / 87.27% branches (uncovered: 171, 174, 177, 262).
   • End-to-end: the Vitest workflow (.github/workflows/vitest.yml) is the only coverage-producing suite in this repo; build.yml runs prebuild against live upstream content but produces no coverage data, so no separate e2e coverage evidence exists to combine. Both helpers are implicitly exercised by prebuild on real content, so this is capped at priority 2 (unit-reachable, no measured e2e).

   Recommendation

   Add unit cases to the two existing test files:

   • rewriteLinks: image → raw URL (project repo and per-file repo), image never routed to a docs route, ./ stripping, anchor-less synced route, case-insensitive match, absolute/anchor images untouched.
   • rewriteLinkTarget: // protocol-relative, empty/whitespace target, lone ?query, ?query preserved on rewrite, untrimmed target returned on skip.

   Not addressable from tests without refactoring: sync-hive-docs.ts:262 (path-traversal refusal) is unreachable because files is a module constant; leaving as-is.

   Priority

   • Impact: medium
   • Effort: low

   ---

   Filed by quality agent (ACMM L4/L6 — full mode)

   ---

   🐝 Hive Agent: quality | Instance: hosted-available-oke-11-placeholder-r05x | SHA: 128d8b5

   — hive: agent=quality backend=copilot model=claude-fable-5.1
4. clubanderson

   closed this as completedin #330on Oct 13, 2026
5. clubanderson commented on Oct 13, 2026

   

   clubanderson

   on Oct 13, 2026

   Member

   More actions

   Done (option A, as org admin).

   1. Workflow change — #330 (🌱 ci: run typecheck and vitest on every PR so they can be required checks), admin-squash-merged as c553506. paths: filters removed from both typecheck.yml and vitest.yml. Verified: the merge commit c553506 touched only .github/workflows/* and still triggered TypeScript & Lint Check and Vitest push runs on main (previously those paths were excluded).

   2. Branch protection —

   gh api -X PATCH repos/hivecommons/docs/branches/main/protection/required_status_checks --input - <<'JSON'
   {"strict": false, "checks": [
     {"context": "Lint and build", "app_id": 15368},
     {"context": "TypeScript & ESLint", "app_id": 15368},
     {"context": "Run unit tests", "app_id": 15368},
     {"context": "Audit production dependencies", "app_id": 15368}
   ]}
   JSON
   

   Read-back:

   $ gh api repos/hivecommons/docs/branches/main/protection/required_status_checks --jq '{strict,contexts}'
   {"contexts":["Lint and build","TypeScript & ESLint","Run unit tests","Audit production dependencies"],"strict":false}
   

   • typecheck.yml paths: filters removed
   • vitest.yml paths: filters removed
   • main requires Lint and build, TypeScript & ESLint, Run unit tests, Audit production dependencies