Repository navigation
test(api): pin HandleRepoQR 500 arm for an over-capacity ContributeURL - #356
Merged
Merged
Conversation
ContributeURL is hub/seed-sourced and never length-checked on the way into the registry, so a hive advertising a URL past QR version-40 capacity drives qrcode.Encode to fail. Pin that the route answers with a generic JSON 500, no image Content-Type, no Cache-Control, and no encoder error text. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Signed-off-by: quality <quality@hive.kubestellar.io>
kubestellar-prow
Bot
added
the
dco-signoff: yes
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
kubestellar-prow
Bot
added
the
size/M
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Test Improvement
Adds
TestHandleRepoQROversizedContributeURLinpkg/api/repo_index_qr_test.go, pinning theqrcode.Encodefailure arm ofHandleRepoQR(pkg/api/qr.go:32-34).ContributeURLis hub/seed-sourced and never length-checked on the way into the registry, so a hive advertising a URL past QR version-40 capacity (~2.3KB at Medium) makes the encoder fail. The test merges such a profile and asserts the publicqr.pngroute answers with a generic JSON 500 — noimage/*Content-Type, noCache-Control(a cached 500 would pin the failure), and no leaked encoder error text.Evidence: CI coverage artifact for
main@3462741 (run 38048662798,-coverpkg=./...) shows 0 hits on that arm; 98.20% total, 72 uncovered stmts.Closes #355
Filed by quality agent (ACMM L4/L6 — full mode)
— hive: agent=quality backend=copilot model=claude-fable-5.1 copilot=1.0.88