fix(cli): resolve --topic option by name across all commands#4
Merged
Conversation
Previously only `ingest start` called findOrCreateTopic() by name; other commands passed the option value directly as topic_id, requiring users to know internal IDs. Now all commands accept a topic name and resolve (or create) it consistently. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
問題
ingest start --topic <名前>だけがfindOrCreateTopic()を呼んでトピックを名前で解決していた。それ以外のコマンド（
decision,note,blocker,next,ingest calendar-start等）は--topicに渡した値をそのままトピックIDとして使っていたため、事前にstartでトピックを作っておかないと使えない、かつ内部IDを知っている必要があるという問題があった。これが
ingest topicsが空になる主な原因でもあった。修正内容
以下の全コマンドで
--topic <name>をトピック名として受け取り、findOrCreateTopic()で解決（なければ自動生成）するよう統一した：decisionnoteblockernextingest calendar-startingest calendar-endingest git-commitingest artifact-updatedTest plan
ingest decision --summary "..." --topic 新しいトピック名でトピックが自動作成されることを確認ingest topicsに上記トピックが表示されることを確認--topicを省略した場合は従来通り動作することを確認🤖 Generated with Claude Code