Skip to content

Add Edit button to open positions #139

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
heyitsStylez merged 1 commit into from
Aug 19, 2026
Merged

Add Edit button to open positions #139

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions src/js/core/06-render-table.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -145,6 +145,7 @@ function _openRow(r) {
+ '<td class="' + (isHolding ? 'mu' : 'cr') + '">' + (isHolding ? '&mdash;' : '+$' + fmt(r.premium)) + '</td>'
+ '<td>' + aprStr + '</td>'
+ '<td class="td-act"><div class="row-actions">' + actions
+ '<button class="btn-qa btn-qa-edit" onclick="openEditModal(' + r.id + ')" title="Edit">Edit</button>'
+ '<button class="btn-d" onclick="deleteTrade(' + r.id + ')" title="Delete">&#10005;</button>'
+ '</div></td>'
+ '</tr>';
Expand Down Expand Up @@ -234,6 +235,7 @@ function _openCard(r) {
+ '<div><span class="exp-card-lbl">APR</span> ' + aprStr + '</div>'
+ '</div>'
+ '<div class="exp-card-row3"><div class="row-actions">' + actions
+ '<button class="btn-qa btn-qa-edit" onclick="openEditModal(' + r.id + ')" title="Edit">Edit</button>'
+ '<button class="btn-d" onclick="deleteTrade(' + r.id + ')" title="Delete">&#10005;</button></div></div>'
+ '</div>';
}
Expand Down
16 changes: 16 additions & 0 deletions test/integration/wheeler-app.test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -190,6 +190,22 @@ test('Wheeler open option row shows a Close button; HyperWheel does not', async
'HyperWheel closes come from chain-sync — no manual Close button');
});

test('open positions expose an Edit button (both apps)', async (t) => {
const seed = [
{ id: 7, asset: 'PURR', type: 'CALL', date: '2026-01-05', expiry: '2026-02-05', dte: 31,
strike: 65, size: 100, premium: 100, outcome: 'OPEN', closeCost: 0, platform: 'MANUAL' },
];
const wheeler = await setupJsdom({ app: 'tradfi', trades: seed });
t.after(wheeler.teardown);
const openBody = wheeler.window.document.getElementById('ttbody-open').innerHTML;
assert.match(openBody, /btn-qa-edit/, 'open row should offer an Edit button');
assert.match(openBody, /openEditModal\(7\)/, 'Edit opens the modal with no preset outcome');

const crypto = await setupJsdom({ app: 'crypto', trades: [{ ...seed[0], id: 8, asset: 'BTC', strike: 90000, size: 0.05, platform: 'RYSK' }] });
t.after(crypto.teardown);
assert.match(crypto.window.document.getElementById('ttbody-open').innerHTML, /openEditModal\(8\)/);
});

test('edit modal closes an open option: sets CLOSED + closeCost, nets premium', async (t) => {
const seed = [
{ id: 7, asset: 'PURR', type: 'CALL', date: '2026-01-05', expiry: '2026-02-05', dte: 31,
Expand Down
Loading