Skip to content

fix: preserve explicit zero caption grain - #3032

Open
miguel-heygen wants to merge 1 commit into
mainfrom
fix/grain-zero-1785872503
Open

fix: preserve explicit zero caption grain#3032
miguel-heygen wants to merge 1 commit into
mainfrom
fix/grain-zero-1785872503

Conversation

@miguel-heygen

@miguel-heygen miguel-heygen commented Aug 4, 2026

Copy link
Copy Markdown
Collaborator

fixes reported:1785872503.756319; no related claim remains outstanding

Source claim: https://slack.com/archives/C0BGC335AQY/p1785872503756319

Summary:

  • preserve an explicit plate grain value of zero instead of replacing it with the default
  • omit the FFmpeg noise filter when resolved grain is zero
  • retain noise=alls=5 when the grain setting is absent

Regression coverage:

  • explicit grain zero compiles without a noise filter
  • missing grain continues to compile with the default level

Verification:

  • node --check skills/embedded-captions/scripts/make-theme.cjs
  • node --test skills/embedded-captions/scripts/make-theme.test.mjs (2 passed)
  • bun run test:skills (463 passed)
  • bunx oxlint changed files
  • bunx oxfmt --check changed files

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant