fix(core): publish missing subpath exports#1616
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
@hyperframes/studio@0.6.115and@hyperframes/sdk@0.6.115import public@hyperframes/coresubpaths that the published@hyperframes/corepackage does not expose. Next/Turbopack fails the consuming app build with missing modules for@hyperframes/core/beats,@hyperframes/core/storyboard, and@hyperframes/core/html-attr-safety.What this fixes
publishConfig.exports:./beats,./storyboard,./html-attr-safety,./package.json, and./runtime/clipTree.dist/runtime/clipTree.{js,d.ts}so the existing./runtime/clipTreesource export has a valid published target..jsextensions.scripts/verify-packed-manifests.mjsso release verification fails when a source export is missing from the published export map.Root cause
packages/core/package.jsonhad the new subpaths in the developmentexportsmap, butpublishConfig.exportswas not updated alongside them. The release path appliespublishConfigto the packed npm manifest, so the registry package hid files that were present in the tarball. The beats export also exposed a second packaging issue: once the subpath was visible, its emitted barrel imported extensionless relative modules, which installed Node ESM consumers cannot resolve.Verification
Local checks
bun installbun run --filter @hyperframes/core buildnode scripts/verify-packed-manifests.mjsbun run --filter @hyperframes/core test -- src/beats src/storyboard src/runtime/clipTree.ts src/utils/htmlAttrSafety.tsgit diff --checkbunx oxfmt --check packages/core/package.json packages/core/src/beats/index.ts packages/core/tsconfig.json scripts/verify-packed-manifests.mjsbunx oxlint packages/core/src/beats/index.ts scripts/verify-packed-manifests.mjsscripts/verify-packed-manifests.mjs, but the gate passed.Packed package proof
Packed
packages/corewithpnpm --dir packages/core pack, installed the tarball into a throwaway consumer, and verified:Browser verification
No browser pass was run for this package-manifest fix. The affected Vercel app cannot consume the correction until a new HyperFrames package version is published and the internal app is bumped to that fixed version.
Notes
0.6.115/0.6.116artifacts.