feat(cli): keyframes command — surface GSAP motion + 3D onion-skin --shot#1603
Open
miguel-heygen wants to merge 9 commits into
Open
feat(cli): keyframes command — surface GSAP motion + 3D onion-skin --shot#1603miguel-heygen wants to merge 9 commits into
miguel-heygen wants to merge 9 commits into
Conversation
…shot Read-then-edit-source tool for GSAP motion. Surfaces every tween's keyframes as data; --shot renders a true-3D onion-skin of the real element (samples the live timeline at N steps; rotation/scale/opacity/colour/3D, not just x/y) for visual self-verify. Multi-stroke pen-up traces for holed/detached shapes. Framing: --layout strip (filmstrip), --from/--to (time window), --no-fit, --angle (orbit camera). Pure geometry+SVG in keyframesShotLayout.ts (unit-tested). Ships the hyperframes-keyframes skill. Depends only on what's already in main.
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| let projectName: string; | ||
| let projectDir: string | undefined; | ||
| if (raw && raw.endsWith(".html") && existsSync(raw) && statSync(raw).isFile()) { | ||
| comps = [surfaceComposition(readFileSync(raw, "utf-8"), basename(raw), raw)]; |
One viewpoint hides depth — a flip reads as a static stack head-on, a tumble looks flat. Mandate ≥3 angles (front+top+side/iso) for any 3D motion, and --layout strip for in-place/overlapping motion.
…t-write-wins) When a brief has channels independent in phase or rate (orbit + axial spin, path + flap, bounce + roll), layer them across nested elements (parent=trajectory, child=secondary) instead of cramming one tween; --shot --selector the leaf shows the composition.
A nested child's rendered motion is composed with its animated ancestors, but the per-element text/JSON surface showed only the child's own tween — hiding a parent's path (a judge/agent reading text would miss it). Now each tween is annotated with its animated DOM ancestors and their motion EXTENT (per-property min..max, so a closed loop still reveals its travel).
…aligned squash vs spin, heading=tangent, per-channel check) + composed-surface note
2 tasks
…nel & motion-trail patterns
…eadless blank-render gotchas (perspective+SVG, attr-keyframes)
… absent from the reference
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Standalone CLI keyframes command, decoupled from the keyframes-studio gt stack — depends only on what's already in
main(the core GSAP parser, compiler, and CLI internals).What it does
npx hyperframes keyframes— a read-then-edit-source tool for GSAP motion (never writes files).--jsonfor exact data).--shot <png>renders a true-3D onion-skin of the real element: seeks the live timeline at N steps and draws the element at each (rotation / scale / opacity / colour / 3D — not just x/y), so you self-verify the rendered motion beforerender. Runs on any animated element.?'s dot, separate letters) — one element, multiple strokes, no false connector.Framing controls (so you inspect exactly what you're editing)
--layout strip— filmstrip (one cell per keyframe); separates in-place / overlapping motion.--from <s> --to <s>— sample one phase densely.--angle front|iso|top|side|yaw,pitch— orbit camera; reveals 3D that's ambiguous head-on.--no-fit— disable zoom-to-fit.Notes
keyframesShotLayout.ts); the headless path only samples.main: typecheck, oxlint, oxfmt, 20 unit tests, and fallow (complexity) all green.