Skip to content

Update dependency review workflow with new GHSA IDs #55

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
chrisvlopez wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Update dependency review workflow with new GHSA IDs #55

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion .github/workflows/dependency-review.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -209,8 +209,12 @@ jobs:
# unsupported by us).
# filelock: https://github.com/advisories/GHSA-w853-jp5j-5j7f
# filelock: https://github.com/advisories/GHSA-qmgc-5h2g-mvrw
# filelock: https://github.com/advisories/GHSA-5v7r-6r5c-r473
# filelock: https://github.com/advisories/GHSA-j47w-4g3g-c36v
allow-ghsas: >-
GHSA-w853-jp5j-5j7f,
GHSA-qmgc-5h2g-mvrw
GHSA-qmgc-5h2g-mvrw,
GHSA-5v7r-6r5c-r473,
GHSA-j47w-4g3g-c36v,
Copy link
Copy Markdown

@cursor cursor Bot May 13, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Trailing comma on last allow-ghsas list entry

Low Severity

The last entry GHSA-j47w-4g3g-c36v, has a trailing comma, which is inconsistent with the established pattern in this file (e.g., pkg:npm/strtok3 on line 204 has no trailing comma). With the >- block scalar, this produces a string ending in , which could result in an empty entry when the dependency-review-action splits by comma, potentially causing unexpected behavior depending on how the action handles empty strings.

Fix in Cursor Fix in Web

Reviewed by Cursor Bugbot for commit f8a93df. Configure here.


comment-summary-in-pr: on-failure