refactor(build): centralize the build gate graph in xtask - #2887
Open
slepp wants to merge 16 commits into
Open
Conversation
Restore structural bootstrap dependencies, point MIR coverage at the consolidated snapshot, and keep license generation byte-identical to the freshness check.
slepp
force-pushed
the
refactor/coherent-build-system
branch
from
August 12, 2026 05:43
a276713 to
4664da4
Compare
Contributor
Author
|
I do not think this branch is safe to land as-is. The first deterministic failure is the sandbox parity contract: the Makefile no longer exposes the recipe shape the check requires, and the Linux preflight also reports four failed commands. Current main has since changed the preflight dispatcher in #2944 and hardened tool provisioning in #2927, while this branch conflicts across a 186-file, 72k-line build rewrite. With the dotted-path cutover imminent, I recommend restating only the still-wanted build changes as fresh, bounded PRs rather than attempting a wholesale rebase. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Build and CI entry points now derive gate dependencies, required tools, platform setup, and timeout policy from xtask. The Makefile remains a thin facade, while compiled Hew test caching preserves identities, successful verdicts, and failure evidence across fixture changes. Review the gate dependency graph and the cache invalidation boundaries.
Verification
cargo test --workspace --no-run: workspace test targets compilecargo xtask gate cutover-contract: cutover and timeout contracts passcargo xtask gate freebsd-contract: centralized FreeBSD setup contract passescargo xtask tools --gates ci --field tools: the selected gate set resolves its required toolsOut of scope