Skip to content

Add jsonFile argument for context#8

Open
larsimmisch wants to merge 6 commits into
heuermh:masterfrom
larsimmisch:master
Open

Add jsonFile argument for context#8
larsimmisch wants to merge 6 commits into
heuermh:masterfrom
larsimmisch:master

Conversation

@larsimmisch

Copy link
Copy Markdown

Extend .gitignore for VSCode junk & extend README.md

Extend .gitignore for VSCode junk & extend README.md
@heuermh

heuermh commented Jul 24, 2020

Copy link
Copy Markdown
Owner

Hello @larsimmisch, thank you for the pull request! This looks like a great idea to me. Please let me know when you think this is ready to merge.

@larsimmisch

Copy link
Copy Markdown
Author

Thanks!

I'll run some more tests on Monday and I'll let you know once they pass.

This is necessary to make `if` clauses work templates (JSONObject throws for nonexisting keys,
while VelocityObject doesn't)
@larsimmisch

Copy link
Copy Markdown
Author

I ran some tests with nested data and had to make a change (otherwise I would have broken if). See f17e681.

I also added an option to let the commandline control PARSER_HYPHEN_ALLOWED.

I think this is useful as it is now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants