Repository navigation
Fix uri wiring fragment - #315
Merged
Merged
Conversation
added 2 commits
November 6, 2026 22:27
The fragment of a uri wiring (#ref_key=...&ref_id_type=..., attrs, use_default_value) was parsed from the query instead of the fragment. So it was silently ignored, and a uri with both filters and a fragment was rejected with "Extra inputs are not permitted". Fragment values are now single values (a key given twice is an error) and attrs is parsed from json. The checks for metadata types (ref_key, ref_id_type) and for ref_id ran before the uri was expanded into the wiring fields. With an explicit adapter_id they rejected wirings whose missing fields the uri provides. They now only run on the expanded wiring. The uri still overrides the fields it contains. Assisted-by: Claude Code:claude-opus-5-5
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.