This repository was archived by the owner on Aug 26, 2021. It is now read-only.
Fix pool not working bugs and autocommit#25
Open
kid143 wants to merge 2 commits intoheroku-python:masterfrom
Open
Fix pool not working bugs and autocommit#25kid143 wants to merge 2 commits intoheroku-python:masterfrom
kid143 wants to merge 2 commits intoheroku-python:masterfrom
Conversation
|
Hi!, i have the same problems with the autocommit transaction. Is there any location to install this app with this bug already fixed up with pip? Thanks! |
|
I made a temporary fork on pypi with this patch for easier installation. Note I am not the author of this patch and have not thoroughly tested the fork. |
|
Also I don't think this actually fixes the autocommit issue. I still see it with this patch applied. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The original implementation do not get new connection from the pool so it is actually not working.
and when creating test db, there's always a 'CREATE DATABASE' in a transaction block error due to
the lack of reimplementation of
_set_autocommitmethod for the proxied connection.I tried to fix these two bugs and it is now working in Django 1.7, I think it should also work for older
version.