This repository was archived by the owner on Nov 13, 2020. It is now read-only.
add environment vars to pre/post compile hook#23
Open
nraynaud wants to merge 10 commits intoheroku-python:masterfrom
sereema:master
Open
add environment vars to pre/post compile hook#23nraynaud wants to merge 10 commits intoheroku-python:masterfrom sereema:master
nraynaud wants to merge 10 commits intoheroku-python:masterfrom
sereema:master
Conversation
|
Hi, i just saw your PR. I don't thing you should export anything here. If you'd want to access the vars in the hooks, the hooks need to be sourced. Currently they are just executed. You could do this step in your hooks than, since you'd have access to |
|
@codingjoe can you elaborate on 'the hooks need to be sourced'? I don't understand your suggestion |
|
If they are not sourced, you don't have access to variables defined in the compile script unless they have been exported, which they don't. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Those are visible in the default python buildpack, but are noticeably absent from the conda buildpack.
They are useful for migrating the database.