Skip to content

Conversation

@asopov-here
Copy link
Contributor

Currently, SDK requires C++11 minimum.
So, boost::optional type is used for optional values. For C++17 and above more convenient is to use std::optional instead. The task NLAM-23 is about making this type configurable. This commit is a third part of the task: olp-cpp-sdk-read.

Relates-To: NLAM-23

@codecov
Copy link

codecov bot commented Aug 8, 2025

Codecov Report

❌ Patch coverage is 91.86992% with 20 lines in your changes missing coverage. Please review.
✅ Project coverage is 80.27%. Comparing base (ba2156c) to head (cb9c5b2).
⚠️ Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
...ataservice-read/src/repositories/QuadTreeIndex.cpp 60.00% 4 Missing ⚠️
...dataservice-read/src/generated/api/MetadataApi.cpp 50.00% 3 Missing ⚠️
...ce-read/include/olp/dataservice/read/DataRequest.h 86.67% 2 Missing ⚠️
...d/include/olp/dataservice/read/PartitionsRequest.h 83.33% 2 Missing ⚠️
...e/olp/dataservice/read/PrefetchPartitionsRequest.h 71.43% 2 Missing ⚠️
...read/include/olp/dataservice/read/CatalogRequest.h 85.71% 1 Missing ⚠️
...clude/olp/dataservice/read/CatalogVersionRequest.h 87.50% 1 Missing ⚠️
...nclude/olp/dataservice/read/PrefetchTilesRequest.h 91.67% 1 Missing ⚠️
...ce-read/include/olp/dataservice/read/TileRequest.h 88.89% 1 Missing ⚠️
olp-cpp-sdk-dataservice-read/src/TaskSink.h 0.00% 1 Missing ⚠️
... and 2 more
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1627      +/-   ##
==========================================
- Coverage   80.32%   80.27%   -0.06%     
==========================================
  Files         349      349              
  Lines       13946    13952       +6     
  Branches     1492     1493       +1     
==========================================
- Hits        11202    11199       -3     
- Misses       2146     2152       +6     
- Partials      598      601       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@asopov-here asopov-here force-pushed the NLAM-23-std-optional branch from ad19ece to 8a9bb0b Compare August 8, 2025 09:40
@asopov-here asopov-here marked this pull request as ready for review August 8, 2025 10:01
@asopov-here asopov-here requested a review from mykolamalik August 8, 2025 16:37
@asopov-here asopov-here force-pushed the NLAM-23-std-optional branch from 0b71fee to 9ce5a4d Compare August 8, 2025 16:41
@asopov-here asopov-here force-pushed the NLAM-23-std-optional branch from 9ce5a4d to 7104fb6 Compare August 11, 2025 08:03
Currently, SDK requires C++11 minimum.
So, boost::optional type is used for optional values.
For C++17 and above more convenient is to use std::optional instead.
The task NLAM-23 is about making this type configurable.
This commit is a third part of the task: olp-cpp-sdk-read.
Also, initial name "optional.hpp" is changed to optional.h
to avoid clang-format header sorting issue.

Relates-To: NLAM-23
Signed-off-by: sopov <ext-alexander.sopov@here.com>
@asopov-here asopov-here merged commit 0678e1e into master Aug 11, 2025
25 checks passed
@asopov-here asopov-here deleted the NLAM-23-std-optional branch August 11, 2025 10:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants