fix(detect): recognize versioned Python agent wrappers - #2188
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
📝 WalkthroughWalkthroughPython runtime detection now recognizes executables such as ChangesPython runtime detection
Estimated code review effort: 2 (Simple) | ~10 minutes 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
Greptile SummaryThis PR restores agent detection for versioned Python launchers by recognizing numeric Python runtime suffixes and inspecting the wrapped script path.
Confidence Score: 5/5The PR appears safe to merge. No blocking failure remains.
|
| Filename | Overview |
|---|---|
| src/detect/mod.rs | Extends Python runtime classification to numeric versioned names and verifies Hermes detection through a versioned Nix Python wrapper. |
Reviews (3): Last reviewed commit: "Merge branch 'master' into fix/versioned..." | Re-trigger Greptile
There was a problem hiding this comment.
Pull request overview
Improves agent-process detection so Hermes (and other wrapped agents) can be recognized when launched via versioned Python runtimes (e.g., python3.12), which is common with Nix-managed installs.
Changes:
- Extend generic runtime detection to treat
python<version>(e.g.,python3.12) as a Python runtime. - Route versioned Python runtimes through the same “wrapped script name” parsing used for
python/python3. - Add a regression test covering the observed
python3.12 .../bin/hermesprocess shape.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
763e3e5 to
05a52af
Compare
|
Note GitHub couldn't provide a complete incremental comparison for this pull request, so CodeRabbit is performing a full review instead. This review may take a little longer. |
Summary
python3.12python3.12 .../bin/hermesprocess shapeVerification
masterwithNoneinstead ofHermesjust lint: passedjust ciwas run locally; three unrelated live-handoff/API integration tests failed and one was reproduced unchanged onorigin/masterin a clean worktreeNo documentation change is needed; this restores existing Hermes detection behavior for versioned Python launchers.