fix(build_db): Rule 4 — ASD AE29F-series requires configure_flash3 (algo 0x06) - #42
Open
dim20 wants to merge 1 commit into
Open
fix(build_db): Rule 4 — ASD AE29F-series requires configure_flash3 (algo 0x06)#42dim20 wants to merge 1 commit into
dim20 wants to merge 1 commit into
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request updates the programming algorithm from 5 to 6 for the ASD AE29F-series chips (AE29F1008, AE29F2008, and AE29F4008) in the database generation script tools/build_db.py and the database file firestarter/data/chip_database.json. Feedback points out that the database file was not fully regenerated, as the entry for AE29F2008 is still configured with algorithm 5 instead of 6.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
…lgo 0x06) AE29F1008, AE29F2008, and AE29F4008 use the AMD command set for erase which requires the 6-byte software unlock sequence (configure_flash3 / algorithm 0x06). Upstream infoic.xml assigns algorithm 0x05 (FLASH_AMD_STD / configure_flash4) which sends a hardware VPP pulse these chips ignore, causing erase to silently fail the blank check. Added Rule 4 to tools/build_db.py (alongside existing Rules 1-3) to flip proto_id 0x05->0x06 for these three chips. chip_database.json updated manually to match (upstream infoic.xml currently has a malformed comment that blocks ET.fromstring parsing; will regenerate cleanly once upstream fixes it). AE49F2008 from the same manufacturer already uses 0x06 upstream.
dim20
force-pushed
the
fix/ae29f-algo-override
branch
from
July 17, 2026 12:46
a744162 to
11fd5a1
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
AE29F1008, AE29F2008, and AE29F4008 use the AMD command set for erase which requires the 6-byte software unlock sequence (configure_flash3 / algorithm 0x06). Upstream infoic.xml assigns algorithm 0x05 (FLASH_AMD_STD / configure_flash4) which sends a hardware VPP pulse these chips ignore, causing erase to silently fail the blank check.
Changes:
tools/build_db.py: Added Rule 4 (alongside existing Rules 1-3) to flip proto_id 0x05->0x06 for AE29F1008/2008/4008firestarter/data/chip_database.json: Updated algorithm 5->6 for all three chipsAE49F2008 from the same manufacturer already correctly uses algorithm 0x06 upstream.
Confirmed fix works on AE29F2008 with a RURP shield on Arduino Uno.