Skip to content

chore: unblock CI (iOS cocoapods install + pre-existing lint) - #972

Open
shahidrogers wants to merge 1 commit into
henninghall:masterfrom
shahidrogers:chore/fix-ci-cocoapods-and-lint
Open

chore: unblock CI (iOS cocoapods install + pre-existing lint)#972
shahidrogers wants to merge 1 commit into
henninghall:masterfrom
shahidrogers:chore/fix-ci-cocoapods-and-lint

Conversation

@shahidrogers

@shahidrogers shahidrogers commented Jul 3, 2026

Copy link
Copy Markdown

Unblocks the currently-red CI. Both fixes are correct for master but, due to how CI is wired, can only take effect once merged — see the note at the bottom for why this PR's own checks stay red.

1. Build / iOS — CocoaPods install aborts before building

The setup-cocoapods step runs a global gem install cocoapods -v 1.11.3 on the pinned Ruby 2.7.5, which now fails:

gem install cocoapods -v 1.11.3
ERROR: ffi requires Ruby version >= 3.0, < 4.1.dev. The current ruby version is 2.7.5.203.

That global CocoaPods is unusedyarn pods runs bundle exec pod install, which uses the Gemfile-locked CocoaPods (1.12.1, with ffi 1.15.5 — both compatible with Ruby 2.7.5). The preceding Setup Ruby step already runs bundle install via bundler-cache: true.

Fix: remove the redundant setup-cocoapods step so the workflow relies solely on the bundled CocoaPods. This removes the known blocker; a fully green iOS run can only be observed on master after merge (or via a push/dispatch run of this branch's workflow on a fork).

2. Check / Lint — pre-existing prettier errors

src/DatePickerIOS.js has two auto-fixable prettier/prettier errors that fail Lint on master. Applied eslint --fix.


Why this PR's own Check / Lint and Build / iOS stay red

pr.yml triggers on pull_request_target, so both the reusable-workflow definitions and the default actions/checkout are taken from the base branch (master), not from this PR:

  • Check / Lint lints master's code (this PR's DatePickerIOS.js fix is never checked out), so it keeps reporting the two pre-existing errors.
  • Build / iOS runs master's build-ios.yml (still containing setup-cocoapods), so it fails identically regardless of this PR's contents.

Once merged, push-main.yml builds iOS with the corrected workflow, and every subsequent PR's Lint (which lints master) goes green. Only CI config + formatting changes here — no library code.

The iOS build fails at the 'setup-cocoapods' step: it runs a global
`gem install cocoapods -v 1.11.3` on the pinned Ruby 2.7.5, but the
current `ffi` gem requires Ruby >= 3.0, so the install aborts before any
build runs. That global CocoaPods is unused — `yarn pods` runs
`bundle exec pod install`, which uses the Gemfile-locked CocoaPods
(1.12.1 with ffi 1.15.5, both compatible with Ruby 2.7.5). Remove the
redundant step so the workflow relies solely on the bundled CocoaPods.

Also apply the auto-fixable prettier formatting in src/DatePickerIOS.js
that was already failing the Lint check on master.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant