fix: stop auth login depending on a checkout .certs/ directory - #23
Merged
Merged
Conversation
Homebrew installs the PHAR, not the repository, so a new machine could not reauthenticate after brew install. Login now issues the callback TLS material under ~/.config/conta-azul-cli/certs/.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
O que muda e por quê
O Homebrew instala o PHAR, não o repositório.
auth loginexigia certificados em.certs/ao lado debin/, então numa máquina novabrew installnão bastava para reautenticar.O comando agora emite a CA e o certificado em
~/.config/conta-azul-cli/certs/e instala a CA no trust store do usuário. O default deCA_REDIRECT_URIpassa a serhttps://conta-azul-cli.ddev.site:9876/callback.CA_CALLBACK_CERT/CA_CALLBACK_KEYcontinuam como override; caminhos apontando para um checkout que não existe nesta máquina são ignorados.Inclui o bump de patch para 0.19.3.
Checklist
composer lintpassa (cobrebin/ca)vendor/bin/phpunitpassavendor/bin/phpstan analyse src/ --level=maxsem errosAPI_COVERAGE.mdatualizado no mesmo commitCOMMANDS.mdatualizadoTest plan
brew install(ou o PHAR) +ca config init+ credenciais +ca auth logincompleta o OAuth sem apontarCA_CALLBACK_CERT/CA_CALLBACK_KEYpara um checkoutCA_CALLBACK_CERT/CA_CALLBACK_KEYapontando para arquivos existentes, esses caminhos continuam valendoca config showlistaCA_REDIRECT_URIcomohttps://conta-azul-cli.ddev.site:9876/callbackquando a variável não está definida