fix: paginar financeiro alteracoes como as outras listagens - #21
Merged
Merged
Conversation
The API already accepts pagina and tamanho_pagina, but the command never exposed the flags and the client never sent them. Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
O que muda e por quê
GET /v1/financeiro/eventos-financeiros/alteracoesjá aceitapaginaetamanho_pagina, mas o comando não expunha--pagina/--tamanho-paginae o cliente não mandava os parâmetros. Passar essas flags nocainstalado virava só o sinopse do comando, sem erro.O comando passa a enviar os dois, com o mesmo default do restante do CLI (
1/50). A referência gerada e o endpoint no manifesto deixam de mostrar a nota de formato de data no lugar do path.Checklist
composer lintpassa (cobrebin/ca)vendor/bin/phpunitpassavendor/bin/phpstan analyse src/ --level=maxsem errosdocs/financial-apis-openapi.yamle a referência gerada atualizados no mesmo commit (API_COVERAGE.md/COMMANDS.mdnão existem mais)docs/_data/commands/financeiro.yaml+composer docs:generate(commands.json,docs/referencia/)Made with Cursor