chore: raise the minimum PHP version to 8.4.1 - #17
Merged
Merged
Conversation
The CLI's own code needs nothing that only exists in 8.4.1. PHPUnit 13, adopted with the other dev-tooling updates, requires php >= 8.4.1, so declaring ^8.4 left a development install on exactly 8.4.0 failing during dependency resolution rather than against a stated requirement. Raising the floor makes the declaration honest. For anyone who only installs the CLI the practical effect is nil: require-dev is never resolved for them, and 8.4.1 superseded 8.4.0. Also updates the places that state the requirement — the README badge and both "Requisitos" sections — so the docs do not contradict composer.json.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
O código do CLI não precisa de nada que só exista no 8.4.1. Quem exige é o
PHPUnit 13, adotado no #16 junto com as outras atualizações de ferramentas
de desenvolvimento: ele declara
php >= 8.4.1.Declarar
require: php ^8.4enquanto orequire-devexige>= 8.4.1deixavaum install de desenvolvimento em 8.4.0 exato falhar na resolução de
dependência em vez de bater num requisito declarado — erro de composer em vez
de mensagem clara. Subir o piso faz a declaração dizer a verdade.
Para quem só instala o CLI o efeito prático é nulo:
require-devnão éresolvido para consumidores, e o 8.4.1 substituiu o 8.4.0.
Alcance
composer.json:^8.4->^8.4.1(e ocontent-hashdo lock)docs/guia/instalacao.md: seção "Requisitos" e a prosa do Homebrew[Unreleased], já que estreitar quem consegue instalar émudança user-facing — diferente do bump de dependência de dev do chore(deps-dev): update PHPUnit, PHP_CodeSniffer, Doctrine CS and Infection #16
A matriz do CI não muda:
setup-phpcom8.4já resolve para o patch maisrecente, bem acima do 8.4.1.
Verificação local
505 testes / 1644 asserções, PHPStan sem erros, phpcs limpo,
docs:checkemdia,
composer validate --strictválido e o dependency analyser semapontamentos.