Repository navigation
test: update v4 test expectations to match Tailwind's documented CSS flattening - #18
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Updates the expected CSS strings in the
import directiveandplugin directivetest suites (v4) to match Tailwind's documentedselector-flattening behavior. These 4 tests were failing on
unmodified
main, unrelated to any other changes.What was happening
The tests expected nested output, e.g.:
but Tailwind actually produces flat selectors:
Per the Tailwind docs on nesting,
Tailwind uses Lightning CSS to flatten nested CSS into flat selectors
so it's understood by all modern browsers, this is expected,
documented behavior, deviating from the expected strings in the tests.
Changes
import directive/plugin directive(should add variants,should add arbitrary values)to the flat-selector shape Tailwind actually produces.
package.json.Testing
All 6 tests (2 legacy v3, 4 v4) pass locally after this change.