Use asyncio.Lock for thread-safe token refresh#8
Draft
Copilot wants to merge 2 commits intooauth-refresfrom
Draft
Use asyncio.Lock for thread-safe token refresh#8Copilot wants to merge 2 commits intooauth-refresfrom
Copilot wants to merge 2 commits intooauth-refresfrom
Conversation
Co-authored-by: hco <156839+hco@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Update oauth token refresh support implementation
Use asyncio.Lock for thread-safe token refresh
Nov 20, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The token refresh mechanism used a boolean flag
_refresh_in_progressto prevent concurrent refreshes, which is not thread-safe in async contexts. Multiple tasks hitting auth errors simultaneously could all pass the check before any set the flag, triggering duplicate refresh attempts.Changes:
_refresh_in_progressboolean withasyncio.LockBefore:
After:
Addresses #6 (comment)
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.