Add first draft for using keycloack as idp and delegating auth to it#33
Open
Add first draft for using keycloack as idp and delegating auth to it#33
Conversation
Open
emrdagkusu
approved these changes
Mar 19, 2022
emrdagkusu
requested changes
Mar 19, 2022
Collaborator
There was a problem hiding this comment.
I just realized that, we are not actually storing the password of users and we are just creating new users with same password in our MongoDB database. When we create a user the user is being created in Keycloak and after that we are creating a user inside MongoDB database with provided information. There is a problem in here, it is not possible to delete users from our MongoDB database although users can be deleted from Keycloak after giving the permission to users about deleting. We should add functionality to delete users from both MongoDB and Keycloak.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I added the keycloak as identity provider and changed the frontend and backend to use it for authorization/authentication instead of implementing our own user system.
For the tests and etc, now it is configurable that you can use the old way of authentication.