Skip to content

Get GitHub file sizes via API [DI-693] - #101

Merged
JackPGreen merged 6 commits into
hazelcast:masterfrom
JackPGreen:get-github-file-sizes-via-api
Oct 21, 2026
Merged

JackPGreen merged 6 commits into
hazelcast:masterfrom
JackPGreen:get-github-file-sizes-via-api

Conversation

@JackPGreen

@JackPGreen JackPGreen commented Oct 16, 2026 •

Copy link
Copy Markdown
Contributor

The fix in #95 did not work correctly - the GitHub browser_download URL only works via a browser with cookie authentication, not via token authentication - for that, you have to use the API.

Re-engineered to use GitHub API to query file sizes for OS release, and from pre-prod repo via curl for EE releases.

Testing:

@JackPGreen
JackPGreen force-pushed the get-github-file-sizes-via-api branch from 83739d6 to 8872cc3 Compare October 19, 2026 09:55
@JackPGreen
JackPGreen marked this pull request as ready for review October 19, 2026 11:37
@JackPGreen JackPGreen changed the title Get GitHub file sizes via API Get GitHub file sizes via API [DI-693] Oct 19, 2026
Comment thread .gitignore Resolved

@nishaatr nishaatr left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sorry should have been Request changes

@JackPGreen
JackPGreen requested a review from nishaatr October 21, 2026 09:42
@JackPGreen
JackPGreen merged commit ef5641f into hazelcast:master Oct 21, 2026
3 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants