Repository navigation
fix: recognise Flask login decorators as sign-in checks - #125
Merged
haydenschmitty merged 1 commit intoNov 15, 2026
Merged
Conversation
Owner
|
Merged and released in 0.9.0. Thank you! Update with |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this changes
Fixes #123. The logging exclusion
log\w*also matches Flask-Login'slogin_requiredand names such aslogin_required_json. Exclude theloginword from that logging pattern so these routes count as protected.The regression fixture includes protected read/write routes, three logging-only routes, and a misplaced login decorator. Logging-only endpoints and the misplaced decorator still produce warnings. The fixture is based on the issue's reported shape.
How I tested it
main: the two protected endpoints are reported as open. It passes with this change.npm test: 290 tests, 289 passed, 1 platform skip, 0 failed.claude plugin validate .: passed.49943b5a94413a530761350f04e896f76e8d620e) before and after. Both find the same 12 routes and identical Health findings. Its local login wrapper was already resolved; this checks for regressions on a real project.Checklist
npm testpassesclaude plugin validate .passesCHANGELOG.mdupdated, if people will notice the change