refactor(Semantics/Events): merge Defs.lean into Basic.lean#34
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Merges
Events/Defs.leanintoEvents/Basic.lean(one file for theEventtype + itsnamespace EventAPI) and deletesDefs.lean; repoints the lone other importer andLinglib.lean.The split's rationale lapsed after the
EventSort → Features.Dynamicityunification:Defsthen had to importFeatures.Aktionsart(for thesortfield's type), and only one file importedDefswithout also importingBasic— so neither the import-weight nor the recompilation-isolation payoff remained. Also landsisAction/isStatein prefix-freenamespace Eventform (consistent with the rest of the block).