refactor(Studies): disaggregate PIP — relocate to Studies, consume Core, Prop-native#21
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PIP (Plural Intensional Presuppositional predicate calculus, Keshet & Abney) was a 6-file framework masquerading as theory-layer substrate in
Semantics/PIP/, despite being consumed only by its own author program. This relocates it toStudies/KeshetAbney2024/, makes it consume Core's modal logic and quantifier theory instead of duplicating them, and removes the Bool-as-predicate machinery..must/.mightnow areCore.Logic.Intensional.boxR/diamondRby construction;BAccessRel(duplicated Bool accessibility) deleted forAccessRel. Bridge theorems collapse toIff.rfl.pipEvery/pipSome(byte-identical copies ofCore.Quantification.every_sem/some_sem) and their re-proved conservativity/monotonicity;setEvery/setSomenow bridge straight to Core and inheritevery_conservativeetc.truth/felicitousand all model predicates;Fintype/FiniteDomain/noncomputableplumbing dropped. Genuine boolean data (coverage table) staysBool.Post-merge a multi-reviewer audit drove follow-up fixes in this PR: removed a vacuous
K ≤ Tlemma, corrected paper item-number citations (verified against the SP/Glossa PDFs), and fixed stalesorry-claiming docstrings.Deferred to a follow-up PR (pre-existing, not Bool→Prop): the hypothesis-circular
must_allows/might_blockslemmas → reformalize via the incremental-discourse-felicity condition so the modal does real work; the 2024→2025 chronological import dependency;PIPExpr:=PIPExprF Emptydeduplication.