refactor(Semantics): drop ProbMonad + redundant Cont laws for mathlib#16
Merged
Conversation
hawkrobe
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removes two more hand-rolled reinventions of Lean's monad infrastructure from the
Composition/+Dynamic/layer, using mathlib'sMonad/LawfulMonadinstead.ProbMonad(Dynamic/Effects/Probability.lean): a bespoke class re-declaringMonad+LawfulMonad(pure/bind + the three laws as fields), with zero instances and zero external consumers. Deleted (along with its hand-rolledmap/seq/map_id/map_comp= mathlib'sFunctor.map/id_map/comp_map);PState/CondProbMonad/ChoiceProbMonadnow build on[Monad P]/[LawfulMonad P], keeping onlyobserve/fail/choose.Contlaws (Composition/Continuation.lean): the standalonerflmonad-law theorems duplicated theLawfulMonad (Cont R)thatEffects.leanregistered downstream. Moved theMonad/LawfulMonad (Cont R)instances toContinuation.lean(the type's home) and dropped the redundant laws;Effects.leanno longer re-registers them.PMF/Cont Rare the canonical instances. No external consumers of the removed declarations.