This repository was archived by the owner on Dec 15, 2019. It is now read-only.
Support private keys with passwords#1
Open
numberoverzero wants to merge 2 commits intohawkowl:masterfrom
Open
Conversation
This change allows users to sign with a private key that has a
password.
The new test key rsa_private_pass.pem has the password "hunter2"
and was generated from rsa_private.pem with the following command:
ssh-keygen -p -f rsa_private.pem -N hunter2
and the new test expects the same output as test_default.
Author
|
The test failures don't seem related to this change. The py32 failure I believe is failing on pip, which notes that 3.0-3.2 are no longer supported: The pypy3 tests are failing I think because cryptography.io considers this a < 2.6 version of pypy? I'm also not sure what to do with this. The same 3.0-3.2 warning from pip also appears. |
Author
|
@hawkowl Anything I can do to help this along? I'm pretty sure dropping py32 from .travis.yml would fix the failure above, but that's orthogonal to this change. If you'd prefer to keep testing on py32 (and whatever's wrong with pypy) I can look for solutions. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change allows users to sign with a private key that has a password.
The new test key is
rsa_private_pass.pemwith the passwordhunter2and was generated fromrsa_private.pemwith the following command:The new test
test_passwordis identical totest_defaultexcept in setting up the HeaderSigner.There's a bit of noise from doing a quick linting pass while I was reading the source. I can revert that if you prefer.
tox passed for py27, py33, py34, and I ran py35 since I use that primarily. I haven't set up py32, pypy, or pypy3. I don't think they'll matter for this change since it's just plumbing a value through. Let me know if you want me to set them up and test as well.