Repository navigation
fix(statusbar): keep a one-column gap between sections when no separator is set - #901
Merged
Merged
Conversation
…tor is set render_group advanced past the gap only when a separator was set, while group_width, the right/center positions and the priority fit count one column per section. Without a separator, sections ran together and the right group ended short of the edge. Fixes #886
hawk90
enabled auto-merge (squash)
October 8, 2026 23:43
hawk90
pushed a commit
that referenced
this pull request
Oct 9, 2026
🤖 I have created a release *beep* *boop* --- ## [3.8.0](v3.7.0...v3.8.0) (2026-10-09) ### Features * **msrv:** raise the minimum supported Rust version to 1.95 ([#906](#906)) ([32231da](32231da)) ### Bug Fixes * **event:** cut large pastes on a char boundary and drop key releases ([#905](#905)) ([7f718c8](7f718c8)) * **statusbar:** keep a one-column gap between sections when no separator is set ([#901](#901)) ([dbd5838](dbd5838)) * **text:** stop char wrapping from looping forever on a wide char that does not fit ([#904](#904)) ([fbc43af](fbc43af)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
render_groupadvanced past the gap after a section only when a separator was set, butgroup_width, the center/right positions and the priority fit (#841) count section + 1. With the default (no separator),left_text("main").left_text("UTF-8")drewmainUTF-8, and two right sections ended a column short of where separated ones sit.Now every section is followed by a one-column gap; the separator char is drawn in it only between two sections, as before.
Tests (in
statusbar/render.rs) failed before the fix: sections without a separator keep a gap, and right sections sit in the same columns with or without a separator.Fixes #886
🤖 Generated with Claude Code