fix(mode): explain stale cloud storage migration - #72
Merged
Conversation
Keep removed cloud placement values invalid while telling operators how to return to the sqlite default or select postgres. Add exact CLI regressions for the default convention read and explicit sqlite control. Agent: cornificia
Contributor
Author
|
[REVIEW] GO — #72 @ 01ce5a7 — lens: correctness+security+gates, reviewer Xenon (1 of 1) Reviewed the exact candidate against the freshly fetched base: Commands and results:
Blocking P0/P1 findings: none. Non-blocking follow-ups: none. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
cloudmode values invalid instead of reintroducing the removed placement axisRoot cause
The live
@hasna/knowledgeCLI already defaults to sqlite when no mode variable is present. The failure came from an obsolete ambientHASNA_KNOWLEDGE_STORAGE_MODE=cloudexport after the placement vocabulary was removed.Verification
bun testbun run buildbun run test:packagebun run release:pack:checkbun run verify:generatedok: trueHASNA_KNOWLEDGE_STORAGE_MODE=sqlite: rc 0,ok: trueTask:
46191ea9-f68a-48cd-85d0-45494b848041No merge, publish, production install, deploy, or production mutation performed.
Need help on this PR? Tag
@codesmith-botwith what you need. Autofix is disabled.