Skip to content

fix: update conversations send workflow contract - #74

Merged
andrei-hasna merged 1 commit into
mainfrom
fix/64-conversations-send-positional-5195e4f9
Aug 8, 2026
Merged

fix: update conversations send workflow contract#74
andrei-hasna merged 1 commit into
mainfrom
fix/64-conversations-send-positional-5195e4f9

Conversation

@andrei-hasna

@andrei-hasna andrei-hasna commented Aug 8, 2026

Copy link
Copy Markdown
Contributor

Summary

  • update the agent workflow template conversations send examples to the installed positional contract
  • replace stale --space/--content send flags with --channel plus explicit --from
  • add a two-sided parser fixture test for generated send commands

Refs #64
Todos: 5195e4f9-4f81-4794-86f8-c135c7413ffb

Validation

  • conversations --version: 0.5.33
  • conversations send --help: Usage: conversations send [options] ; options include --from and --channel, not --content or --space
  • bun test scripts/seed-workflow.test.ts: 3 pass, 0 fail, 13 expect() calls
  • bun test: 635 pass, 0 fail, 2656 expect() calls
  • bun run typecheck: tsc --noEmit exit 0
  • bun run build: exit 0
  • disposable readback: agent-workflow-template contains positional send commands and no stale generated send flags
  • package-manager-scan repo-only: clean, 2 files
  • staged diff secrets scan: filesScanned 1, findingCount 0, errors []

Scope

Stopped before independent review, merge, publish, install, or managed-home render rollout.


View with [code]smith Autofix with [code]smith
Need help on this PR? Tag @codesmith-bot with what you need. Autofix is disabled.

Refs #64

Todos: 5195e4f9-4f81-4794-86f8-c135c7413ffb

Agent: vitruvius
@andrei-hasna

Copy link
Copy Markdown
Contributor Author

[REVIEW] GO — #74 @ 62bbc9b — lens: correctness+security+gates, reviewer Aruns (1 of 1)

Reviewed the exact PR candidate against freshly fetched origin/main b9f6ed9.

What I ran (stdout and stderr captured separately; exit codes measured unpiped):

  • git log --oneline origin/main..HEAD — exit 0.
  • git diff origin/main...HEAD --stat — exit 0; 2 files changed, 147 insertions, 2 deletions.
  • git diff origin/main...HEAD — exit 0; full diff read.
  • conversations send --help — exit 0; confirms conversations send [options] <message> with --channel <name> and --from <agent>.
  • bun install — exit 0; setup only, not reported as a test gate.
  • bun run typecheck — exit 0; pass, no pass/fail counts emitted by tsc --noEmit.
  • bun run test — exit 0; 635 pass, 0 fail, 2656 expect() calls, 55 files.

What I read:

  • Full diff for scripts/seed-workflow.ts and new scripts/seed-workflow.test.ts.
  • Complete surrounding source for both changed files.
  • scripts/seed.ts, package.json, and repository references to seed-workflow / agent-workflow-template / conversations send.
  • Installed CLI help for the exact conversations send surface.

Blocking P0/P1 findings: none. The generated examples now match the reachable installed CLI contract, the regression fixture exercises the two generated commands and rejects the stale --space / --content form, and the change introduces no new credential, authorization, mutation, or trust-boundary path.

Non-blocking follow-ups: none.

@andrei-hasna
andrei-hasna merged commit 9fe30cc into main Aug 8, 2026
3 checks passed
@andrei-hasna
andrei-hasna deleted the fix/64-conversations-send-positional-5195e4f9 branch August 8, 2026 00:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant