fix(presence): preserve omitted heartbeat context - #135
Conversation
|
[REVIEW] GO — #135 @ 10973a1 — lens: correctness+security+gates, reviewer unresolved-account013 (1 of 1) Reviewed the full diff against origin/main at 7683229 and surrounding source for all six changed files: src/lib/presence.ts, src/lib/presence.test.ts, src/lib/store/api-store.ts, src/lib/store/api-store.test.ts, src/server/api.ts, and src/server/api.test.ts. I also traced ConversationsStore callers, the heartbeat CLI/MCP call sites, request parsing, and the SQLite/PostgreSQL agent_presence schemas and unique-agent indexes. Commands and gates:
Blocking P0/P1 findings: none. The authenticated heartbeat path now preserves omitted project and metadata fields on existing rows while explicit null/empty values still replace them, and the local SQLite and remote HTTP/PostgreSQL paths are consistent for the supported store calls. Non-blocking follow-ups: none. |
|
[REVIEW] NO_GO — #135 @ 10973a1 — lens: correctness+security+gates, reviewer unresolved-account013 (1 of 1) Focused pre-merge gate correction: the required base-movement check failed after the initial GO was posted. Blocking P1 finding: required compatibility gate is stale. Rebase the PR branch onto current main, rerun Non-blocking follow-ups: none. |
Keep stored project focus and metadata when heartbeat fields are omitted, while preserving explicit clear and replacement behavior across HTTP and SQLite. Task: CON2-00048 Task: 64bd104d-a414-44cd-a48a-ae6c649d3c02 Agent: cossus
10973a1 to
6e9b792
Compare
|
[REVIEW] GO — #135 @ 6e9b792 — lens: correctness+security+gates, reviewer unresolved-account013 (1 of 1) Focused re-review of the named compatibility-gate defect and its direct regressions: the branch was rebased onto current main at 7683229, producing head 6e9b792. The six-file heartbeat diff is unchanged, and the combined candidate now includes the intervening SDK generation and attachment changes that the previous merge ref lacked. Commands and gates on the rebased candidate:
Blocking P0/P1 findings: none. The prior base-staleness blocker is resolved. Non-blocking follow-ups: none. |
|
Probe correction for the earlier base-staleness comment: that The corrected explicit-ref probe returned:
The latest |
Summary
Validation
bun test src/server/api.test.ts src/lib/presence.test.ts src/lib/store/api-store.test.ts— 130 pass, 0 failbun test— 1790 pass, 0 failbun run typecheckbun run buildTask: CON2-00048
Todo: 64bd104d-a414-44cd-a48a-ae6c649d3c02
Need help on this PR? Tag
@codesmith-botwith what you need. Autofix is disabled.