Skip to content

Conversation

@L0neGamer
Copy link
Contributor

This is unncessary, so I'm suggesting we remove it.

@Kleidukos
Copy link
Member

@L0neGamer I can't approve the decision for @sjshuck but I'd suggest you also add a changelog entry. :) Did you find it was redundant through a GHC warning?

@L0neGamer
Copy link
Contributor Author

L0neGamer commented Jan 22, 2026

I found it was redundant because I recalled that the Monad instance for writer does not require Writer, and yet when using CPS.WriterT with a state monad and a writer that did not at that moment have a Monoid constraint, I got a compile time error when I shouldn't have.

for example:

adjustState :: WriterT w (State Int) ()
adjustState = modify' succ

shouldn't fail with CPS.WriterT.

There should be a warning for this, I'll dig it up (note: -Wredundant-constraints is turned on it seems but doesn't do anything here) and bump the changelog.

@sjshuck
Copy link
Collaborator

sjshuck commented Jan 22, 2026

Thanks!

@sjshuck sjshuck merged commit f718724 into haskell:master Jan 22, 2026
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants