cycles.c: add powerpc64* support#291
Merged
Merged
Conversation
RyanGlScott
reviewed
Jul 1, 2026
RyanGlScott
left a comment
RyanGlScott
left a comment
Member
There was a problem hiding this comment.
Great, thank you for the pull request! One minor suggestion, but otherwise I'm happy to land this.
Currently build fails on FreeBSD/powerpc64{le,} without that.
RyanGlScott
added a commit
that referenced
this pull request
Jul 2, 2026
Member
|
I've uploaded |
Contributor
Author
|
The changelog says:
But it's not really true. That instruction only works on 64-bit PowerPC, won't work on 32-bit. This is how glibc does it: |
Member
|
Sorry, my mistake! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently build fails on FreeBSD/powerpc64{le,} without that.