Merged
Conversation
f17c3ec to
1d240e4
Compare
1d240e4 to
734b276
Compare
Member
Author
|
@peterbecich I extended your implementation of Edit: I'll merge the PR now since it's working, but feel free to comment here and I can make fixups in a subsequent PR |
4dae703 to
a119235
Compare
a119235 to
946c6b7
Compare
This was referenced Mar 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR does two things:
flake.nixmechanism for development;Fixes #612 and #727
Modernization
There were a few issues that needed to be fixed.
The most important is that I could not get the
dbLensesandtableLensesmechanism so compile on GHC 9.8 or 9.10. I recall there were changes toImpredicativeTypesin GHC 9.8, so it could be why. Instead, I generated lenses usingmicrolens-th'smakeLenses, and edited the section on lenses accordingly (i.e. practically removed it).This introduced
TemplateHaskellin some of the examples. Unfortunately,runhaskelldoesn't work well with staged compilation of files containingTemplateHaskell. Therefore, we build examples withrunhaskellUNLESS Template Haskell is involved, in which case we use the much slowerghc --make -O0.